MaxGekk commented on a change in pull request #28434:
URL: https://github.com/apache/spark/pull/28434#discussion_r418935761
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSessionCatalogSuite.scala
##########
@@ -63,4 +63,27 @@ class DataSourceV2SQLSessionCatalogSuite
}
}
}
+
+ test("SPARK-31624: SHOW TBLPROPERTIES working with V2 tables and the session
catalog") {
+ val t1 = "tbl"
+ withTable(t1) {
+ sql(s"CREATE TABLE $t1 (id bigint, data string) USING $v2Format
TBLPROPERTIES " +
+ s"(key='v', key2='v2')")
Review comment:
's' is not needed
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSessionCatalogSuite.scala
##########
@@ -63,4 +63,27 @@ class DataSourceV2SQLSessionCatalogSuite
}
}
}
+
+ test("SPARK-31624: SHOW TBLPROPERTIES working with V2 tables and the session
catalog") {
+ val t1 = "tbl"
+ withTable(t1) {
+ sql(s"CREATE TABLE $t1 (id bigint, data string) USING $v2Format
TBLPROPERTIES " +
+ s"(key='v', key2='v2')")
+
+ checkAnswer(
+ sql(s"SHOW TBLPROPERTIES $t1"),
+ Seq(Row("key", "v"), Row("key2", "v2"))
+ )
Review comment:
Put ')' at the end of previous line
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSessionCatalogSuite.scala
##########
@@ -63,4 +63,27 @@ class DataSourceV2SQLSessionCatalogSuite
}
}
}
+
+ test("SPARK-31624: SHOW TBLPROPERTIES working with V2 tables and the session
catalog") {
+ val t1 = "tbl"
+ withTable(t1) {
+ sql(s"CREATE TABLE $t1 (id bigint, data string) USING $v2Format
TBLPROPERTIES " +
+ s"(key='v', key2='v2')")
+
+ checkAnswer(
+ sql(s"SHOW TBLPROPERTIES $t1"),
+ Seq(Row("key", "v"), Row("key2", "v2"))
+ )
+
+ checkAnswer(
Review comment:
This can fit to 100 chars?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
