viirya commented on a change in pull request #28331:
URL: https://github.com/apache/spark/pull/28331#discussion_r419049624
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -650,6 +656,19 @@ private[spark] class BlockManager(
blockId: BlockId,
level: StorageLevel,
classTag: ClassTag[_]): StreamCallbackWithID = {
+ // Delegate shuffle blocks here to resolver if supported
+ if (blockId.isShuffle || blockId.isInternalShuffle) {
+ logDebug(s"Putting shuffle block ${blockId}")
+ try {
+ return indexShuffleResolver.putShuffleBlockAsStream(blockId,
serializerManager)
+ } catch {
+ case e: ClassCastException => throw new Exception(
+ s"Unexpected shuffle block ${blockId} with unsupported shuffle " +
+ s"resolver ${shuffleManager.shuffleBlockResolver}")
+ }
+ }
+ logDebug(s"Putting regular block ${blockId}")
+ // All other blocks
Review comment:
Can a blockId be representing a shuffle block and also a regular block
at same time?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
