MichaelChirico commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-623224648
Thanks @felixcheung. both backports are directly from `base` R: https://github.com/wch/r-source/blob/08ebf253e44e10bfb445f27b53b2a43bc7e6740d/src/library/base/R/utilities.R#L26-L27 https://github.com/wch/r-source/blob/08ebf253e44e10bfb445f27b53b2a43bc7e6740d/src/library/base/R/strwrap.R#L219-L229 Does that mean we need to use the R license header on the `backports.R` file specifically? As for the file ordering, that's [handled by the `Collate` field](https://cran.r-project.org/doc/manuals/r-release/R-exts.html#The-DESCRIPTION-file); I've adjusted the order & pushed. > There was a different way to do method signature compatibility (you should be able to find it), maybe it will work better. I don't follow this, could you ellaborate? Happy to add tests for `mutate`, could you please help point out where such tests should be added? I was a bit confused by the structure of tests. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
