igreenfield commented on a change in pull request #26624:
URL: https://github.com/apache/spark/pull/26624#discussion_r419298231
##########
File path: core/src/main/scala/org/apache/spark/executor/Executor.scala
##########
@@ -674,6 +677,18 @@ private[spark] class Executor(
}
}
+ private def setMDCForTask(taskDescription: TaskDescription): Unit = {
+ val properties = taskDescription.properties
+
+ org.slf4j.MDC.put("appId", properties.getProperty("spark.app.id"))
+ org.slf4j.MDC.put("appName", properties.getProperty("spark.app.name"))
+
+ properties.asScala.filter(_._1.startsWith("mdc.")).foreach { item =>
+ val key = item._1.substring(4)
+ org.slf4j.MDC.put(key, item._2)
Review comment:
exactly, we want all the threads that handle work that connected to
tasks will get MDC so their logs will be traceable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
