tgravescs commented on a change in pull request #27207:
URL: https://github.com/apache/spark/pull/27207#discussion_r419498132
##########
File path:
core/src/main/scala/org/apache/spark/scheduler/TaskSchedulerImpl.scala
##########
@@ -466,12 +503,28 @@ private[spark] class TaskSchedulerImpl(
}.sum
}
+ private def minTaskLocality(
+ l1: Option[TaskLocality],
+ l2: Option[TaskLocality]) : Option[TaskLocality] = {
+ if (l1.isEmpty) {
+ l2
+ } else if (l2.isEmpty) {
+ l1
+ } else if (l1.get < l2.get) {
+ l1
+ } else {
+ l2
+ }
+ }
+
/**
* Called by cluster manager to offer resources on slaves. We respond by
asking our active task
* sets for tasks in order of priority. We fill each node with tasks in a
round-robin manner so
* that tasks are balanced across the cluster.
Review comment:
is there are changes suggested and required, please file a separate new
jira for this and link them. this pr has been merged and we have had to many
followups at this point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
