tgravescs commented on a change in pull request #28009:
URL: https://github.com/apache/spark/pull/28009#discussion_r419502881
##########
File path:
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
##########
@@ -206,6 +214,75 @@ class ClientSuite extends SparkFunSuite with Matchers {
appContext.getPriority.getPriority should be (1)
}
+ test("specify a more specific type for the application") {
+ // Limit to 20 characters
+ val appTypes = Map(
+ 1 -> ("", ""),
+ 2 -> (" ", " "),
+ 3 -> ("SPARK-SQL", "SPARK-SQL"),
+ 4 -> ("012345678901234567890123", "01234567890123456789"))
+
+ for ((id, (sourceType, targetType)) <- appTypes) {
+ val sparkConf = new SparkConf().set("spark.yarn.applicationType",
sourceType)
+ val args = new ClientArguments(Array())
+
+ val appContext =
spy(Records.newRecord(classOf[ApplicationSubmissionContext]))
+ val appId = ApplicationId.newInstance(123456, id)
+ appContext.setApplicationId(appId)
+ val getNewApplicationResponse =
Records.newRecord(classOf[GetNewApplicationResponse])
+ val containerLaunchContext =
Records.newRecord(classOf[ContainerLaunchContext])
+
+ val client = new Client(args, sparkConf, null)
+ val context = client.createApplicationSubmissionContext(
+ new YarnClientApplication(getNewApplicationResponse, appContext),
+ containerLaunchContext)
+
+ val yarnClient = mock(classOf[YarnClient])
+ when(yarnClient.submitApplication(any())).thenAnswer((invocationOnMock:
InvocationOnMock) => {
+ val subContext = invocationOnMock.getArguments()(0)
+ .asInstanceOf[ApplicationSubmissionContext]
+ val request = Records.newRecord(classOf[SubmitApplicationRequest])
+ request.setApplicationSubmissionContext(subContext)
+
+ val rmContext = mock(classOf[RMContext])
+ val conf = mock(classOf[Configuration])
+ val map = new ConcurrentHashMap[ApplicationId, RMApp]()
+ when(rmContext.getRMApps).thenReturn(map)
+ val dispatcher = mock(classOf[Dispatcher])
+ when(rmContext.getDispatcher).thenReturn(dispatcher)
+ when[EventHandler[_]](dispatcher.getEventHandler).thenReturn(
+ new EventHandler[Event[_]] {
+ override def handle(event: Event[_]): Unit = {}
+ }
+ )
+ val writer = mock(classOf[RMApplicationHistoryWriter])
+ when(rmContext.getRMApplicationHistoryWriter).thenReturn(writer)
+ val publisher = mock(classOf[SystemMetricsPublisher])
+ when(rmContext.getSystemMetricsPublisher).thenReturn(publisher)
+ when(appContext.getUnmanagedAM).thenReturn(true)
+
+
Review comment:
nit, remove extra newline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
