xccui commented on pull request #28444: URL: https://github.com/apache/spark/pull/28444#issuecomment-623532777
Hi @HeartSaVioR, thanks for your suggestion. Yes, I'm also not quite sure if doing a while-loop-check is suitable here. I also considered the solutions you mentioned, e.g., making the `AppStatusStore.applicationInfo()` return an optional `ApplicationInfo` or constructing an "empty" `ApplicationInfo` when it's unavailable in the KVStore. I made the current choice because after checking all the invokers of this method, I found they all expect to get a valid `ApplicationInfo`. If this is the so-called contract and we keep the current initialized logic, this fix could just work. However, I can definitely make another choice if we reach a consensus. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
