maropu commented on a change in pull request #28451:
URL: https://github.com/apache/spark/pull/28451#discussion_r419790030
##########
File path: docs/_data/menu-sql.yaml
##########
@@ -156,22 +156,22 @@
url: sql-ref-syntax-qry-select-distribute-by.html
- text: LIMIT Clause
url: sql-ref-syntax-qry-select-limit.html
+ - text: Common Table Expression
+ url: sql-ref-syntax-qry-select-cte.html
+ - text: Inline Table
+ url: sql-ref-syntax-qry-select-inline-table.html
- text: JOIN
url: sql-ref-syntax-qry-select-join.html
- text: Join Hints
url: sql-ref-syntax-qry-select-hints.html
+ - text: LIKE Predicate
+ url: sql-ref-syntax-qry-select-like.html
- text: Set Operators
Review comment:
Why do we need the changes in this file?
##########
File path: docs/sql-ref-identifier.md
##########
@@ -27,54 +27,47 @@ An identifier is a string used to identify a database
object such as a table, vi
#### Regular Identifier
-{% highlight sql %}
+```sql
{ letter | digit | '_' } [ , ... ]
-{% endhighlight %}
+```
Note: If `spark.sql.ansi.enabled` is set to true, ANSI SQL reserved keywords
cannot be used as identifiers. For more details, please refer to [ANSI
Compliance](sql-ref-ansi-compliance.html).
#### Delimited Identifier
-{% highlight sql %}
+```sql
`c [ ... ]`
-{% endhighlight %}
+```
### Parameters
-<dl>
- <dt><code><em>letter</em></code></dt>
- <dd>
+* **letter**
+
Any letter from A-Z or a-z.
- </dd>
-</dl>
-<dl>
- <dt><code><em>digit</em></code></dt>
- <dd>
+
+* **digit**
+
Any numeral from 0 to 9.
- </dd>
-</dl>
-<dl>
- <dt><code><em>c</em></code></dt>
- <dd>
+
+* **c**
+
Any character from the character set. Use <code>`</code> to escape special
characters (e.g., <code>`</code>).
- </dd>
-</dl>
### Examples
-{% highlight sql %}
+```sql
-- This CREATE TABLE fails with ParseException because of the illegal
identifier name a.b
CREATE TABLE test (a.b int);
-org.apache.spark.sql.catalyst.parser.ParseException:
-no viable alternative at input 'CREATE TABLE test (a.'(line 1, pos 20)
+ org.apache.spark.sql.catalyst.parser.ParseException:
Review comment:
Rather, we should remove indents in the other places for following the
result format?
##########
File path: docs/sql-ref-functions-udf-aggregate.md
##########
@@ -113,26 +102,26 @@ OPTIONS (
);
SELECT * FROM employees;
--- +-------+------+
--- | name|salary|
--- +-------+------+
--- |Michael| 3000|
--- | Andy| 4500|
--- | Justin| 3500|
--- | Berta| 4000|
--- +-------+------+
++-------+------+
+| name|salary|
++-------+------+
+|Michael| 3000|
+| Andy| 4500|
+| Justin| 3500|
+| Berta| 4000|
++-------+------+
SELECT myAverage(salary) as average_salary FROM employees;
--- +--------------+
--- |average_salary|
--- +--------------+
--- | 3750.0|
--- +--------------+
-{% endhighlight %}
++--------------+
+|average_salary|
++--------------+
+| 3750.0|
++--------------+
+```
</div>
Review comment:
We cannot avoid this tag, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
