cloud-fan commented on a change in pull request #28366:
URL: https://github.com/apache/spark/pull/28366#discussion_r419877190
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -179,15 +179,22 @@ class DataSourceV2Strategy(session: SparkSession) extends
Strategy with Predicat
case OverwriteByExpression(r: DataSourceV2Relation, deleteExpr, query,
writeOptions, _) =>
// fail if any filter cannot be converted. correctness depends on
removing all matching data.
- val filters = splitConjunctivePredicates(deleteExpr).map {
- filter => DataSourceStrategy.translateFilter(deleteExpr).getOrElse(
- throw new AnalysisException(s"Cannot translate expression to source
filter: $filter"))
- }.toArray
+ val filters = splitConjunctivePredicates(deleteExpr)
+ def transferFilters =
+ (filters: Seq[Expression], supportNestedPredicatePushdown: Boolean) =>
{
Review comment:
Do we need the `supportNestedPredicatePushdown` parameter here as the
caller side always pass true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
