gengliangwang commented on a change in pull request #28459:
URL: https://github.com/apache/spark/pull/28459#discussion_r420545275



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -845,8 +845,9 @@ object SQLConf {
     .doc("When true, enable the metadata-only query optimization that use the 
table's metadata " +
       "to produce the partition columns instead of table scans. It applies 
when all the columns " +
       "scanned are partition columns and the query has an aggregate operator 
that satisfies " +
-      "distinct semantics. By default the optimization is disabled, since it 
may return " +
-      "incorrect results when the files are empty.")
+      "distinct semantics. By default the optimization is disabled, and 
deprecated as of Spark " +

Review comment:
       nit: could you add this note in the comment of the rule as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to