attilapiros commented on a change in pull request #28094:
URL: https://github.com/apache/spark/pull/28094#discussion_r420823338
##########
File path: pom.xml
##########
@@ -2341,7 +2341,7 @@
<plugin>
<groupId>net.alchim31.maven</groupId>
<artifactId>scala-maven-plugin</artifactId>
- <version>4.3.0</version>
+ <version>3.4.4</version>
Review comment:
This must be a mistake I guess.
##########
File path: core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
##########
@@ -38,6 +40,38 @@ private[ui] class EnvironmentPage(
"Java Home" -> appEnv.runtime.javaHome,
"Scala Version" -> appEnv.runtime.scalaVersion)
+ def constructExecutorRequestString(execReqs: Map[String,
ExecutorResourceRequest]): String = {
+ execReqs.map {
+ case (_, execReq) =>
+ val execStr = new StringBuilder()
+ execStr ++= s"\t${execReq.resourceName}: [amount: ${execReq.amount}"
Review comment:
Nit: this lines can be merged into a bit more efficient one:
```scala
val execStr = new StringBuilder(s"\t${execReq.resourceName}: [amount:
${execReq.amount}")
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
