rednaxelafx commented on pull request #28463: URL: https://github.com/apache/spark/pull/28463#issuecomment-624779079
Thank you for the comment, @kiszk san! > One question about test strategy. Is it better to test old style lambda (i.e. w/o indy) against the new closure cleaner, too? In other words, does getSerializationProxy() work correctly? The old/new style closure checks (`isClosure` vs `IndylambdaScalaClosures.getSerializationProxy()`) are always in use. The latter is really a slightly enhanced version of `ClosureCleaner.getSerializedLambda` that already exists in Spark 2.4 and has worked on Scala 2.11 closures. So I have confidence that it'll work fine. That said, it's a good suggestion to have some tests to explicitly the old style lambdas. It's possible to use them in Scala 2.12 by specifying `-Ydelambdafy:inline` to the Scala compiler (or the Scala REPL). It could be a bit of hassle to setup a test suite with a exotic REPL option. At least that can't go to the `SingletonReplSuite`. Maybe tweaking `ReplSuite` a bit can make it happen. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
