Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5029#discussion_r26536774
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertIntoHiveTableSuite.scala
---
@@ -136,6 +135,7 @@ class InsertIntoHiveTableSuite extends QueryTest with
BeforeAndAfter {
assert(listFolders(tmpDir,List()).sortBy(_.toString()) ==
expected.sortBy(_.toString))
sql("DROP TABLE table_with_partition")
sql("DROP TABLE tmp_table")
+ Utils.deleteRecursively(tmpDir)
--- End diff --
I'm torn on this, since it leaves temp files lying around while tests run,
and, doesn't delete them if there's a hard crash. But the extra line of code is
annoying everywhere and not done consistently. Hm.. Maybe the test superclass
can manage a temp dir and delete it between tests. If anyone's interested in
that, I'll go there. Otherwise maybe best to leave it as-is and not add
recursive deletes where there were none before.
(A few of these changes are to make the temp file go in a temp dir instead
of working dir, but most are indeed just about standardization and better
guaranteeing cleanup)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
