cloud-fan commented on a change in pull request #27920:
URL: https://github.com/apache/spark/pull/27920#discussion_r421233022
##########
File path:
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/CliSuite.scala
##########
@@ -460,18 +460,20 @@ class CliSuite extends SparkFunSuite with
BeforeAndAfterAll with BeforeAndAfterE
)
}
- test("SPARK-30049 Should not complain for quotes in commented with
multi-lines") {
+ test("SPARK-31102 spark-sql fails to parse when contains comment") {
runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
- | comment continues here with single ' quote \\
- | extra ' \\
- |;""".stripMargin -> "testcomment"
+ """SELECT concat('test', 'comment'),
+ | -- someone's comment here
+ | 2;""".stripMargin -> "testcomment"
)
+ }
+
+ test("SPARK-30049 Should not complain for quotes in commented with
multi-lines") {
runCliWithin(1.minute)(
- """SELECT concat('test', 'comment') -- someone's comment here \\
Review comment:
so double-slash doesn't work any more?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
