gaborgsomogyi commented on a change in pull request #28368:
URL: https://github.com/apache/spark/pull/28368#discussion_r421454577



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/connection/DB2ConnectionProvider.scala
##########
@@ -48,7 +48,7 @@ private[sql] class DB2ConnectionProvider(driver: Driver, 
options: JDBCOptions)
     result
   }
 
-  override def setAuthenticationConfigIfNeeded(): Unit = {
+  override def setAuthenticationConfigIfNeeded(): Unit = 
SecurityConfigurationLock.synchronized {

Review comment:
       I haven't added any reference because:
   * This pattern in security is a standard
   * This is a detail from user perspective. The important thing from that 
perspective is that every previously configured entry is still visible, 
untouched and the configured database credentials will be configured internally.
   
   What I can imagine is a similar internal doc for developers like 
[this](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/deploy/security/README.md).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to