skonto edited a comment on pull request #25870: URL: https://github.com/apache/spark/pull/25870#issuecomment-625984284
@dongjoon-hyun I think addressed your comments, I missed a few earlier, had to scroll up a bit. There is a pending discussion about the use of `Eventually` but I have explained why I used this way to make sure the resources are cleaned up. Same for the use of the grace period there, it is no harm afaik. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
