HyukjinKwon commented on a change in pull request #28483:
URL: https://github.com/apache/spark/pull/28483#discussion_r422580476
##########
File path: python/pyspark/ml/stat.py
##########
@@ -37,8 +37,8 @@ class ChiSquareTest(object):
"""
@staticmethod
- @since("2.2.0")
- def test(dataset, featuresCol, labelCol):
+ @since("3.1.0")
Review comment:
@huaxingao, let's don't change when the version was added. Also,
`@since` adds `versionadded` automatically into the docstring so I think we can
remove it in the docstring.
In this case, we could add `verstionchanged` directive instead to describe
the difference happened in Spark 3.1.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
