cloud-fan commented on a change in pull request #26624:
URL: https://github.com/apache/spark/pull/26624#discussion_r422889611
##########
File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala
##########
@@ -130,7 +224,15 @@ private[spark] object ThreadUtils {
*/
def newDaemonCachedThreadPool(prefix: String): ThreadPoolExecutor = {
Review comment:
Does your job server use these `ThreadUtil` methods? If it does then
please move these `MDCAware*` classes to your job server codebase.
The executor logs can print the `taskName` via MDC without all these changes
in `ThreadUtil`. The use case you documented in
https://github.com/apache/spark/pull/26624/files#diff-76e731333fb756df3bff5ddb3b731c46R2958
does not need these changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
