HyukjinKwon commented on a change in pull request #28493:
URL: https://github.com/apache/spark/pull/28493#discussion_r422892179
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/QueryExecution.scala
##########
@@ -249,18 +277,25 @@ class QueryExecution(
* Dumps debug information about query execution into the specified file.
*
* @param maxFields maximum number of fields converted to string
representation.
+ * @param explainMode the explain mode to be used to generate the string
+ * representation of the plan.
*/
- def toFile(path: String, maxFields: Int = Int.MaxValue): Unit = {
+ def toFile(path: String,
+ maxFields: Int = Int.MaxValue,
+ explainMode: ExplainMode = ExtendedMode): Unit = {
Review comment:
I would let it take a string instead consistently by
`ExplainMode.fromString(mode)` since `ExtendedMode` under `execution` is
strictly private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
