cloud-fan commented on a change in pull request #28477:
URL: https://github.com/apache/spark/pull/28477#discussion_r422894095
##########
File path:
sql/core/src/main/java/org/apache/spark/sql/execution/datasources/parquet/VectorizedRleValuesReader.java
##########
@@ -211,24 +212,25 @@ public void readIntegersWithRebase(
WritableColumnVector c,
int rowId,
int level,
- VectorizedValuesReader data) throws IOException {
+ VectorizedValuesReader data,
+ final boolean failIfRebase) throws IOException {
Review comment:
means it's immutable and may help to optimize `if (failIfRebase)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
