Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4991#discussion_r26550346
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
 ---
    @@ -30,6 +30,28 @@ abstract class LogicalPlan extends 
QueryPlan[LogicalPlan] with Logging {
       self: Product =>
     
       /**
    +   * Duplicate the current logical plan for resolving the self join
    +   */
    +  def newInstance: this.type = {
    +    assert(resolved)
    +
    +    val newArgs = this.productIterator.map {
    +      case x: LogicalPlan => x.newInstance
    +      case a => a.asInstanceOf[AnyRef]
    +    }.toArray
    +
    +    val defaultCtor = 
getClass.getConstructors.find(_.getParameterTypes.size != 0).head
    +    defaultCtor.newInstance(newArgs: 
_*).asInstanceOf[this.type].transformExpressionsUp {
    --- End diff --
    
    I'd prefer to keep all of the reflection magic in `TreeNode` whenever 
possible.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to