cloud-fan commented on a change in pull request #28501:
URL: https://github.com/apache/spark/pull/28501#discussion_r425125928
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -2125,13 +2196,14 @@ class Analyzer(
condition.find(_.isInstanceOf[AggregateExpression]).isDefined
}
- def resolveHaving(filter: Filter, agg: Aggregate): LogicalPlan = {
- // Try resolving the condition of the filter as though it is in the
aggregate clause
+ def resolveFilterCondInAggregate(
+ filterCond: Expression, agg: Aggregate): (Seq[NamedExpression],
Option[Expression]) = {
Review comment:
How about `Option[(Seq[NamedExpression], Expression)]`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
