LucaCanali commented on a change in pull request #28528:
URL: https://github.com/apache/spark/pull/28528#discussion_r425362757
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -803,6 +803,13 @@ package object config {
.booleanConf
.createWithDefault(true)
+ private[spark] val METRICS_EXECUTOR_SOURCE_ENABLED =
+ ConfigBuilder("spark.metrics.executorSource.enabled")
Review comment:
Thanks @dongjoon-hyun for the quick reaction on this. My reasoning for
adding the possibility of turning the executor source off in this PR, was that
I thought it could help adoption, in the sense that it could be a safety net
for those who may be impacted by the addition of this list of new driver
metrics (in local mode). Also it can be seen as a "simmetric partner" of
`spark.metrics.executorMetricsSource.enabled`. I actually have no use case that
needs to turn the executor source metrics off, so I can for sure split this
part out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
