dongjoon-hyun commented on a change in pull request #28532:
URL: https://github.com/apache/spark/pull/28532#discussion_r425499462



##########
File path: dev/test-dependencies.sh
##########
@@ -47,7 +47,7 @@ OLD_VERSION=$($MVN -q \
     -Dexec.executable="echo" \
     -Dexec.args='${project.version}' \
     --non-recursive \
-    org.codehaus.mojo:exec-maven-plugin:1.6.0:exec)
+    org.codehaus.mojo:exec-maven-plugin:1.6.0:exec | grep -e 
'[0-9]\.[0-9]\.[0-9]')

Review comment:
       It's two lines, @srowen .
   
   **NO FALLBACK**
   ```
   $ build/mvn -q -Dexec.executable="echo" -Dexec.args='${project.version}' 
--non-recursive org.codehaus.mojo:exec-maven-plugin:1.6.0:exec
   Using `mvn` from path: 
/Users/dongjoon/APACHE/spark-merge/build/apache-maven-3.6.3/bin/mvn
   3.1.0-SNAPSHOT
   ```
   
   **FALLBACK**
   ```
   $ build/mvn -q -Dexec.executable="echo" -Dexec.args='${project.version}' 
--non-recursive org.codehaus.mojo:exec-maven-plugin:1.6.0:exec
   Falling back to archive.apache.org to download Maven
   Using `mvn` from path: 
/Users/dongjoon/APACHE/spark-merge/build/apache-maven-3.6.3/bin/mvn
   3.1.0-SNAPSHOT
   ```
   
   **In the script**
   ```
   $ echo (build/mvn -q -Dexec.executable="echo" 
-Dexec.args='${project.version}' --non-recursive 
org.codehaus.mojo:exec-maven-plugin:1.6.0:exec)
   Using `mvn` from path: 
/Users/dongjoon/APACHE/spark-merge/build/apache-maven-3.6.3/bin/mvn
   Falling back to archive.apache.org to download Maven 3.1.0-SNAPSHOT
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to