xuanyuanking commented on a change in pull request #28501:
URL: https://github.com/apache/spark/pull/28501#discussion_r425571365
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -629,12 +629,7 @@ class AstBuilder(conf: SQLConf) extends
SqlBaseBaseVisitor[AnyRef] with Logging
case p: Predicate => p
case e => Cast(e, BooleanType)
}
- plan match {
- case aggregate: Aggregate =>
- AggregateWithHaving(predicate, aggregate)
- case _ =>
- Filter(predicate, plan)
- }
+ UnresolvedHaving(predicate, plan)
Review comment:
Yes, it still works, the `UnresolvedHaving` will be changed to Filter in
rule `ResolveAggregateFunction`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
