Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5033#discussion_r26565348
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/optimization/LBFGS.scala ---
@@ -60,6 +60,8 @@ class LBFGS(private var gradient: Gradient, private var
updater: Updater)
/**
* Set the convergence tolerance of iterations for L-BFGS. Default 1E-4.
* Smaller value will lead to higher accuracy with the cost of more
iterations.
+ * This value must be nonnegative. Lower convergence tolerance is less
tolerant
--- End diff --
Nit: works better as "Lower convergence values are less tolerant and
therefore ..." as you have elsewhere. (I can get to this on merge if you don't
first.) LGTM otherwise. I think we can ignore the Jenkins timeout. I will
verify the docs build before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
