dongjoon-hyun commented on a change in pull request #28554:
URL: https://github.com/apache/spark/pull/28554#discussion_r426177823
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
##########
@@ -264,7 +264,6 @@ object StatFunctions extends Logging {
}
val selectedCols = ds.logicalPlan.output
- .filter(a => a.dataType.isInstanceOf[NumericType] ||
a.dataType.isInstanceOf[StringType])
Review comment:
Can we keep this whitelist style instead of allowing all, @Fokko ? You
can add the missing type here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
