Github user aborsu985 commented on the pull request:
https://github.com/apache/spark/pull/4504#issuecomment-82410900
@mengxr I do not think that LowerCase warrants a transformer but rather it
could be incorporated into a larger string to vector transformer that changes a
text into a vector just like the
[CountVectorizer](http://scikit-learn.org/stable/modules/generated/sklearn.feature_extraction.text.CountVectorizer.html#sklearn.feature_extraction.text.CountVectorizer)
used in scikit learn.
I agree that it is not necessary to have it in the tokenizer though so I
removed it.
I'm working on adding unit tests but I'm having trouble creating a
dataFrame to test it with. Any help would be welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
