HyukjinKwon commented on a change in pull request #28551:
URL: https://github.com/apache/spark/pull/28551#discussion_r426327344
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -251,7 +251,7 @@ object FunctionRegistry {
expression[Log10]("log10"),
expression[Log1p]("log1p"),
expression[Log2]("log2"),
- expression[Log]("ln"),
+ expression[Log]("ln", true),
Review comment:
We should just directly override when it's possible because the tags are
lost when it copies. That's defined in the parent node like that just to cover
other general cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
