Ngone51 commented on a change in pull request #28370:
URL: https://github.com/apache/spark/pull/28370#discussion_r426342699
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -1829,7 +1901,58 @@ private[spark] class BlockManager(
data.dispose()
}
+ /**
+ * Class to handle block manager decommissioning retries
+ * It creates a Thread to retry offloading all RDD cache blocks
+ */
+ private class BlockManagerDecommissionManager(conf: SparkConf) {
Review comment:
For a new reviewer (e.g. me) on a big topic, it's not always possible to
know every detail(even worse, when there's no design doc). So it's the author's
responsibility to give more context. For example, leaving todo JIRA tickets in
the code comment or reply to give more information. But without sufficient
context here, I really think "this change", wrapping a manager around a thread,
doesn't make sense to me.
As for "-1", it really represents my personal opinion. I should say "I don't
like this change" if "-1" means a lot for the community.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
