viirya commented on a change in pull request #28556:
URL: https://github.com/apache/spark/pull/28556#discussion_r426345052
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -82,6 +87,8 @@ object NestedColumnAliasing {
case _: LocalLimit => true
case _: Repartition => true
case _: Sample => true
+ case _: RepartitionByExpression => true
+ case _: Join => true
Review comment:
Yea, I will add more tests for join, like outer join.
The nested column pruning here is for a Project on top of Join (or others).
We just replace original complex output with nested pruned fields. IIUC,
although joins update nullability, for null outputs, those nested pruned fields
should be null too, because the nullability is determined by join semantics.
I will add more tests to verify it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
