Fokko commented on a change in pull request #28554:
URL: https://github.com/apache/spark/pull/28554#discussion_r426402521
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala
##########
@@ -264,7 +264,10 @@ object StatFunctions extends Logging {
}
val selectedCols = ds.logicalPlan.output
- .filter(a => a.dataType.isInstanceOf[NumericType] ||
a.dataType.isInstanceOf[StringType])
+ .filter(a => a.dataType.isInstanceOf[NumericType]
+ || a.dataType.isInstanceOf[StringType]
+ || a.dataType.isInstanceOf[DateType]
Review comment:
I'm working on getting the test suite running on my machine, so I need
some time. I don't think that the `mean` will be the issue, this is just the
element in the middle of the sorted collection, however, the `stddev` will be
tricky. For the StringType this is just `null`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
