HyukjinKwon commented on a change in pull request #28571:
URL: https://github.com/apache/spark/pull/28571#discussion_r426998182
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -390,8 +390,12 @@ case class Cast(child: Expression, dataType: DataType,
timeZoneId: Option[String
if (d.isNaN || d.isInfinite) null else (d * 1000000L).toLong
}
+ // SPARK-31710.Add compatibility flag to cast long to timestamp,
// converting seconds to us
- private[this] def longToTimestamp(t: Long): Long = t * 1000000L
+ private[this] def longToTimestamp(t: Long): Long = {
+ if (SQLConf.get.getConf(SQLConf.LONG_TIMESTAMP_CONVERSION_IN_SECONDS)) t *
1000000L
Review comment:
Let's don't do this. It will require to add the compatibility across all
the date time functionality in Spark, e.g.) `from_unixtime`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
