jerryshao commented on a change in pull request #28525:
URL: https://github.com/apache/spark/pull/28525#discussion_r427016499
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ShuffleIndexInformation.java
##########
@@ -31,17 +34,44 @@
public class ShuffleIndexInformation {
/** offsets as long buffer */
private final LongBuffer offsets;
+ private final boolean hasDigest;
+ /** digests as long buffer */
+ private final LongBuffer digests;
private int size;
public ShuffleIndexInformation(File indexFile) throws IOException {
+ ByteBuffer offsetsBuffer, digestsBuffer;
size = (int)indexFile.length();
- ByteBuffer buffer = ByteBuffer.allocate(size);
- offsets = buffer.asLongBuffer();
+ int offsetsSize, digestsSize;
+ if (size % 8 == 0) {
Review comment:
Would you please explain more about why using `size % 8` to check
whether the index file has digest or not?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
