jiangxb1987 commented on a change in pull request #28579:
URL: https://github.com/apache/spark/pull/28579#discussion_r427086592



##########
File path: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServerDiskManager.scala
##########
@@ -238,10 +240,11 @@ private class HistoryServerDiskManager(
     new File(appStoreDir, fileName)
   }
 
-  private def updateAccessTime(appId: String, attemptId: Option[String]): Unit 
= {
+  private def updateApplicationStoreInfo(

Review comment:
       This function updates both the lastAccess time and the size, so it would 
be better to rename to `updateApplicationStoreInfo`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to