HyukjinKwon commented on a change in pull request #28572:
URL: https://github.com/apache/spark/pull/28572#discussion_r427121973
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/DeserializerBuildHelper.scala
##########
@@ -161,6 +161,10 @@ object DeserializerBuildHelper {
case _: StructType => expr
case _: ArrayType => expr
case _: MapType => expr
+ case _: DecimalType =>
+ // For Scala/Java `BigDecimal`, we accept decimal types of any valid
precision/scale.
+ // Here we use the `DecimalType` object to indicate it.
+ UpCast(expr, DecimalType, walkedTypePath.getPaths)
Review comment:
Can we just directly pass `expected` to `UpCast`, and don't change the
definition of `UpCast`? I think that will fix it less invasively.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
