cloud-fan commented on a change in pull request #28582:
URL: https://github.com/apache/spark/pull/28582#discussion_r427957334
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TimestampFormatter.scala
##########
@@ -100,10 +111,26 @@ class Iso8601TimestampFormatter(
*/
class FractionTimestampFormatter(zoneId: ZoneId)
extends Iso8601TimestampFormatter(
- "", zoneId, TimestampFormatter.defaultLocale, needVarLengthSecondFraction
= false) {
+ TimestampFormatter.defaultPattern,
Review comment:
what's wrong if we still pass the empty string as the pattern?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
