cloud-fan commented on a change in pull request #28128:
URL: https://github.com/apache/spark/pull/28128#discussion_r428427640
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -1064,6 +1055,20 @@ object SparkSession extends Logging {
// Private methods from now on
////////////////////////////////////////////////////////////////////////////////////////
+ private val listenerRegistered: AtomicBoolean = new AtomicBoolean(false)
+
+ /** Register the AppEnd listener onto the Context */
+ private def registerContextListener(sparkContext: SparkContext): Unit = {
+ if (!SparkSession.listenerRegistered.get()) {
Review comment:
nit: we are in the same class so we can remove `SparkSession.`
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala
##########
@@ -1064,6 +1055,20 @@ object SparkSession extends Logging {
// Private methods from now on
////////////////////////////////////////////////////////////////////////////////////////
+ private val listenerRegistered: AtomicBoolean = new AtomicBoolean(false)
+
+ /** Register the AppEnd listener onto the Context */
+ private def registerContextListener(sparkContext: SparkContext): Unit = {
+ if (!SparkSession.listenerRegistered.get()) {
+ sparkContext.addSparkListener(new SparkListener {
+ override def onApplicationEnd(applicationEnd:
SparkListenerApplicationEnd): Unit = {
+ defaultSession.set(null)
+ }
+ })
+ SparkSession.listenerRegistered.set(true)
Review comment:
ditto
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
