Ngone51 commented on a change in pull request #28258:
URL: https://github.com/apache/spark/pull/28258#discussion_r428645814



##########
File path: core/src/main/scala/org/apache/spark/deploy/Client.scala
##########
@@ -176,6 +202,22 @@ private class ClientEndpoint(
       } else if (!Utils.responseFromBackup(message)) {
         System.exit(-1)
       }
+
+    case DriverStatusResponse(found, state, _, _, _) =>

Review comment:
       It would be better if we could do some refactor on `pollAndReportStatus` 
in order to reduce some duplicate logic.
   For example, we can only call `pollAndReportStatus` here, and remove other 
invocations in `SubmitDriverResponse`/ `KillDriverResponse`. And, of course, 
the `pollAndReportStatus`(it also needs a new name) will not poll the status 
anymore.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to