maropu commented on a change in pull request #28560:
URL: https://github.com/apache/spark/pull/28560#discussion_r428969502
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NestedColumnAliasing.scala
##########
@@ -48,7 +53,10 @@ object NestedColumnAliasing {
case Project(projectList, child) =>
Project(
getNewProjectList(projectList, nestedFieldToAlias),
- replaceChildrenWithAliases(child, attrToAliases))
+ replaceChildrenWithAliases(child, nestedFieldToAlias, attrToAliases))
+
+ case other =>
Review comment:
Ah, I see. Thanks for the check. If so, it might be better to explicitly
filiter them here for readablity like `case other if canPruneOn(plan)`, or
leave some comments about that. Both is okay to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
