HyukjinKwon commented on a change in pull request #28600: URL: https://github.com/apache/spark/pull/28600#discussion_r429034529
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/arithmetic.scala ########## @@ -337,11 +340,19 @@ trait DivModLike extends BinaryArithmetic { } else { s"${eval2.value} == 0" } - val javaType = CodeGenerator.javaType(dataType) + val isIntegralDiv = this.isInstanceOf[IntegralDivide] + // From SPARK-16323 IntegralDivision returns Long data type + val javaType = if (isIntegralDiv) JAVA_LONG else CodeGenerator.javaType(dataType) + val operandJavaType = if (isIntegralDiv) operandsDataType match { + case _: IntegerType => JAVA_LONG Review comment: Okay, allowing it seems making sense. It will also keep the compatibility. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org