cloud-fan commented on a change in pull request #28592: URL: https://github.com/apache/spark/pull/28592#discussion_r429070818
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala ########## @@ -33,6 +34,8 @@ sealed trait DateFormatter extends Serializable { def format(days: Int): String def format(date: Date): String def format(localDate: LocalDate): String + + def initialize(): Unit = {} Review comment: shall we force all the children to implement `initialize`? And maybe a better name is `validatePatternString`. `initialize` sounds like it must be called. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org