srowen commented on pull request #28553: URL: https://github.com/apache/spark/pull/28553#issuecomment-632790127
Yeah there are several points in the code that check weights with a `require`. I don't know if they can be refactored easily. Your approach is fine. Other places check it farther downstream inside some other operation but it doesn't matter much. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
