HeartSaVioR commented on a change in pull request #28623:
URL: https://github.com/apache/spark/pull/28623#discussion_r429607587
##########
File path:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/ConsumerStrategy.scala
##########
@@ -54,15 +55,24 @@ private[kafka010] sealed trait ConsumerStrategy {
* Specify a fixed collection of partitions.
*/
private[kafka010] case class AssignStrategy(partitions: Array[TopicPartition])
- extends ConsumerStrategy {
+ extends ConsumerStrategy with Logging {
override def createConsumer(
kafkaParams: ju.Map[String, Object]): Consumer[Array[Byte], Array[Byte]]
= {
val updatedKafkaParams = setAuthenticationConfigIfNeeded(kafkaParams)
+ excludeGroupId(updatedKafkaParams)
Review comment:
I'd rather not manipulate passed map, as we did in
setAuthenticationConfigIfNeeded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
