dbaliafroozeh commented on a change in pull request #28540:
URL: https://github.com/apache/spark/pull/28540#discussion_r429656552
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/joins.scala
##########
@@ -208,3 +208,161 @@ object ExtractPythonUDFFromJoinCondition extends
Rule[LogicalPlan] with Predicat
}
}
}
+
+sealed abstract class BuildSide
+
+case object BuildRight extends BuildSide
+
+case object BuildLeft extends BuildSide
+
+trait JoinSelectionHelper {
Review comment:
@maropu That's true that currently there are no other uses of this
trait, but there are potentially other rules that can use the join selection
logic at optimization time, so this refactoring will open up the opportunity
for more optimization rules.
Also, this cleans up the JoinSelection rule quite a bit, and IMO the logic
for determining the type of the join is more clear now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
