HyukjinKwon commented on a change in pull request #28631:
URL: https://github.com/apache/spark/pull/28631#discussion_r429697192
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -325,7 +325,7 @@ object CreateStruct extends FunctionBuilder {
*/
val registryEntry: (String, (ExpressionInfo, FunctionBuilder)) = {
val info: ExpressionInfo = new ExpressionInfo(
- "org.apache.spark.sql.catalyst.expressions.NamedStruct",
+ getClass.getCanonicalName.stripSuffix("$"),
Review comment:
I guess because `CreateStruct.apply` is the actual `FunctionBuilder`? I
think either way is fine. `CreateNamedStruct` sounds fine to me too. This class
isn't used anywhere in Spark if I am not mistaken so won't be a big deal.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
##########
@@ -325,7 +325,7 @@ object CreateStruct extends FunctionBuilder {
*/
val registryEntry: (String, (ExpressionInfo, FunctionBuilder)) = {
val info: ExpressionInfo = new ExpressionInfo(
- "org.apache.spark.sql.catalyst.expressions.NamedStruct",
+ getClass.getCanonicalName.stripSuffix("$"),
Review comment:
I guess because `CreateStruct.apply` is the actual `FunctionBuilder`? I
think either way seems fine to me. `CreateNamedStruct` sounds fine to me too.
This class isn't used anywhere in Spark if I am not mistaken so won't be a big
deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
