sarutak commented on a change in pull request #28627:
URL: https://github.com/apache/spark/pull/28627#discussion_r429710040
##########
File path: project/SparkBuild.scala
##########
@@ -1001,9 +1004,9 @@ object TestSettings {
javaOptions += "-Xmx3g",
// Exclude tags defined in a system property
testOptions in Test += Tests.Argument(TestFrameworks.ScalaTest,
- sys.props.get("test.exclude.tags").map { tags =>
- tags.split(",").flatMap { tag => Seq("-l", tag) }.toSeq
- }.getOrElse(Nil): _*),
+ sys.props.get("test.exclude.tags").map(tag => tag.split(",").toSeq)
+ .getOrElse(defaultExcludedTagsForScalaTest).filter(!_.trim.isEmpty)
Review comment:
It's what I intended that if developers set `test.excluded.tags`
explicitly, all the tags which are intended to be excluded should be added
explicitly.
But as you concerned, this change seems to break the build compatibility.
I'll submit another idea.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
