wangyum commented on a change in pull request #28626:
URL: https://github.com/apache/spark/pull/28626#discussion_r429753348
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/expressions/ExpressionInfoSuite.scala
##########
@@ -156,4 +158,74 @@ class ExpressionInfoSuite extends SparkFunSuite with
SharedSparkSession {
}
}
}
+
+ test("Check whether should extend NullIntolerant") {
+ // Only check expressions extended from these expressions
+ val parentExpressionNames = Seq(classOf[UnaryExpression],
classOf[BinaryExpression],
+ classOf[TernaryExpression], classOf[QuaternaryExpression],
+ classOf[SeptenaryExpression]).map(_.getName)
Review comment:
This checker only check the expressions extended from these
expressions(`UnaryExpression`, `BinaryExpression`, `TernaryExpression`,
`QuaternaryExpression` and `SeptenaryExpression`) because these expressions are
NullIntolerant by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
