MaxGekk commented on a change in pull request #28646:
URL: https://github.com/apache/spark/pull/28646#discussion_r430700568
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -244,6 +250,12 @@ private object DateTimeFormatterHelper {
for (style <- unsupportedNarrowTextStyle if
patternPart.contains(style)) {
throw new IllegalArgumentException(s"Too many pattern letters:
${style.head}")
}
+ if (bugInStandAloneForm && (patternPart.contains("LLL") ||
patternPart.contains("qqq"))) {
Review comment:
You checked only 'LLL' pattern in `bugInStandAloneForm()` but throws
exception for 'qqq' as well. Are you sure they are directly related?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
