Github user AndreSchumacher commented on a diff in the pull request:

    https://github.com/apache/spark/pull/360#discussion_r11985972
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Row.scala 
---
    @@ -206,6 +206,67 @@ class GenericMutableRow(size: Int) extends 
GenericRow(size) with MutableRow {
       override def copy() = new GenericRow(values.clone())
     }
     
    +// TODO: this is an awful lot of code duplication. If values would be 
covariant we could reuse
    +// much of GenericRow
    +class NativeRow[T](protected[catalyst] val values: Array[T]) extends Row {
    --- End diff --
    
    @marmbrus  Good question. I think I added that because GetField wants to 
get a Row when it calls `eval` on its children. I will have another look at 
that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to